pzampino commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822794727



##########
File path: 
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoImpersonationHttpServletRequestWrapper.java
##########
@@ -25,10 +25,10 @@
 import java.util.List;
 import java.util.Map;
 
-public class IdentityAsserterNoDoAsHttpServletRequestWrapper extends
+public class IdentityAsserterNoImpersonationHttpServletRequestWrapper extends

Review comment:
       Not critical, but following my other comments around naming, this one 
could rather be something like 
`NoImpersonationIdentityAsserterHttpServletRequestWrapper` or 
`NoImpersonationAsserterRequestWrapper`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org


Reply via email to