[
https://issues.apache.org/jira/browse/KNOX-2710?focusedWorklogId=738865&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-738865
]
ASF GitHub Bot logged work on KNOX-2710:
----------------------------------------
Author: ASF GitHub Bot
Created on: 09/Mar/22 15:47
Start Date: 09/Mar/22 15:47
Worklog Time Spent: 10m
Work Description: pzampino commented on a change in pull request #544:
URL: https://github.com/apache/knox/pull/544#discussion_r822794727
##########
File path:
gateway-provider-identity-assertion-no-doas/src/main/java/org/apache/knox/gateway/identityasserter/filter/IdentityAsserterNoImpersonationHttpServletRequestWrapper.java
##########
@@ -25,10 +25,10 @@
import java.util.List;
import java.util.Map;
-public class IdentityAsserterNoDoAsHttpServletRequestWrapper extends
+public class IdentityAsserterNoImpersonationHttpServletRequestWrapper extends
Review comment:
Not critical, but following my other comments around naming, this one
could rather be something like
`NoImpersonationIdentityAsserterHttpServletRequestWrapper` or
`NoImpersonationAsserterRequestWrapper`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
Issue Time Tracking
-------------------
Worklog Id: (was: 738865)
Time Spent: 1h 20m (was: 1h 10m)
> Identity assertion provider for services without doAs support
> -------------------------------------------------------------
>
> Key: KNOX-2710
> URL: https://issues.apache.org/jira/browse/KNOX-2710
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 1h 20m
> Remaining Estimate: 0h
>
> There might be services (e.g. RStudio) which do not support trusted proxy and
> that might break with the doAs parameter at the end of the URL. We need to be
> able to implement an identity assertion provider that can skip doAs and which
> is configurable.
--
This message was sent by Atlassian Jira
(v8.20.1#820001)
