zeroflag commented on code in PR #560:
URL: https://github.com/apache/knox/pull/560#discussion_r854126678


##########
gateway-provider-security-jwt/src/main/java/org/apache/knox/gateway/provider/federation/jwt/filter/JWTAuthCodeAssertionFilter.java:
##########
@@ -55,6 +57,10 @@ public void init( FilterConfig filterConfig ) throws 
ServletException {
     GatewayServices services = (GatewayServices) 
filterConfig.getServletContext().getAttribute(GatewayServices.GATEWAY_SERVICES_ATTRIBUTE);
     authority = services.getService(ServiceType.TOKEN_SERVICE);
     sr = services.getService(ServiceType.SERVICE_REGISTRY_SERVICE);
+
+    this.tokenIssuer = 
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER) != null
+            ? 
filterConfig.getInitParameter(JWTAccessTokenAssertionFilter.ISSUER)

Review Comment:
   I don't know how likely this is, but the doc says it's a StringOrURI not an 
array. If we ever need to support multiple issuers we can still use coma 
separated values I guess, or introduce new application specific claim which is 
an array.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to