pzampino commented on code in PR #561:
URL: https://github.com/apache/knox/pull/561#discussion_r855343918
##########
gateway-shell/src/test/java/org/apache/knox/gateway/shell/knox/token/TokenTest.java:
##########
@@ -42,24 +43,28 @@ public class TokenTest {
@Test
public void testTokenWithNoDoAs() {
- testToken(false, null);
+ testToken(false, null, false);
Review Comment:
I would like us continue to include tests for the original method signature
without the new boolean for including groups. This will help prove backward
compatibility and validate the default behavior to NOT include the group info.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
