[
https://issues.apache.org/jira/browse/KNOX-2735?focusedWorklogId=760149&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-760149
]
ASF GitHub Bot logged work on KNOX-2735:
----------------------------------------
Author: ASF GitHub Bot
Created on: 21/Apr/22 15:55
Start Date: 21/Apr/22 15:55
Worklog Time Spent: 10m
Work Description: pzampino commented on code in PR #561:
URL: https://github.com/apache/knox/pull/561#discussion_r855343918
##########
gateway-shell/src/test/java/org/apache/knox/gateway/shell/knox/token/TokenTest.java:
##########
@@ -42,24 +43,28 @@ public class TokenTest {
@Test
public void testTokenWithNoDoAs() {
- testToken(false, null);
+ testToken(false, null, false);
Review Comment:
I would like us continue to include tests for the original method signature
without the new boolean for including groups. This will help prove backward
compatibility and validate the default behavior to NOT include the group info.
Issue Time Tracking
-------------------
Worklog Id: (was: 760149)
Time Spent: 20m (was: 10m)
> Add support for group info inclusion in tokens to the KnoxShell client
> ----------------------------------------------------------------------
>
> Key: KNOX-2735
> URL: https://issues.apache.org/jira/browse/KNOX-2735
> Project: Apache Knox
> Issue Type: Improvement
> Components: KnoxShell
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> org.apache.knox.gateway.shell.knox.token.Token should support the recently
> added query param for requesting that JWTs include the authenticated user's
> group associations.
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
