[GitHub] [knox] smolnar82 opened a new pull request, #569: KNOX-2740 - Impersonation-related fields should be displayed only if that's enabled in the topology for the KnoxToken service

[GitBox]

smolnar82 opened a new pull request, #569:
URL: https://github.com/apache/knox/pull/569

   ## What changes were proposed in this pull request?
   
   Added a new KnonToken service level configuration to enable/disable token 
impersonation. It's called `knox.token.impersonation.enabled` and defaults to 
`true`. Using this boolean config we can show/hide impersonation-related fields 
in Knox UIs.
   
   ## How was this patch tested?
   
   Manual testing:
   
   1. `knox.token.impersonation.enabled=true` or w/o declaring this config
   
   Token Management UI:
   <img width="1781" alt="image" 
src="https://user-images.githubusercontent.com/34065904/166899212-fe849eb3-4c5d-4be6-9d03-f3f16fcb4115.png";>
   
   Token Generation UI:
   <img width="1748" alt="image" 
src="https://user-images.githubusercontent.com/34065904/166899141-30c24349-e842-4296-be8e-82371528ce36.png";>
   
   2. `knox.token.impersonation.enabled=false`
   
   Token Management UI:
   <img width="1784" alt="image" 
src="https://user-images.githubusercontent.com/34065904/166899409-ea233c7a-2ca0-4cc1-a4d6-129243453246.png";>
   
   Token Generation UI:
   <img width="1756" alt="image" 
src="https://user-images.githubusercontent.com/34065904/166899493-fb3cd817-a956-4579-b40a-939bc5dd8be3.png";>
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org