[jira] [Updated] (KNOX-2747) RemoteAliasService generates password without checking if it already exists

[Attila Magyar (Jira)]

     [ 
https://issues.apache.org/jira/browse/KNOX-2747?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

Attila Magyar updated KNOX-2747:
--------------------------------
    Description: 
RemoteAliasService:

{code}
    /* Generate a new password  */
    if (generate) {
      generateAliasForCluster(clusterName, alias);
    }
{code}

DefaultAliasService checks first

{code}
      credential = keystoreService.getCredentialForCluster(clusterName, alias);
      if (credential == null && generate) {
        generateAliasForCluster(clusterName, alias);
        credential = keystoreService.getCredentialForCluster(clusterName, 
alias);
      }
{code}

This causes the Pac4jDispatcherFilter to regenerate the password at each 
topology change.

  was:
RemoteAliasService:

{code}
    /* Generate a new password  */
    if (generate) {
      generateAliasForCluster(clusterName, alias);
    }
{code}

DefaultAliasService checks first

{code}
      credential = keystoreService.getCredentialForCluster(clusterName, alias);
      if (credential == null && generate) {
        generateAliasForCluster(clusterName, alias);
        credential = keystoreService.getCredentialForCluster(clusterName, 
alias);
      }
{code}


> RemoteAliasService generates password without checking if it already exists
> ---------------------------------------------------------------------------
>
>                 Key: KNOX-2747
>                 URL: https://issues.apache.org/jira/browse/KNOX-2747
>             Project: Apache Knox
>          Issue Type: Bug
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>
> RemoteAliasService:
> {code}
>     /* Generate a new password  */
>     if (generate) {
>       generateAliasForCluster(clusterName, alias);
>     }
> {code}
> DefaultAliasService checks first
> {code}
>       credential = keystoreService.getCredentialForCluster(clusterName, 
> alias);
>       if (credential == null && generate) {
>         generateAliasForCluster(clusterName, alias);
>         credential = keystoreService.getCredentialForCluster(clusterName, 
> alias);
>       }
> {code}
> This causes the Pac4jDispatcherFilter to regenerate the password at each 
> topology change.



--
This message was sent by Atlassian Jira
(v8.20.7#820007)