moresandeep commented on code in PR #579:
URL: https://github.com/apache/knox/pull/579#discussion_r878446759
##########
gateway-provider-identity-assertion-common/pom.xml:
##########
@@ -85,8 +85,23 @@
<groupId>org.eclipse.jetty</groupId>
<artifactId>jetty-util</artifactId>
</dependency>
+ <dependency>
+ <groupId>org.jboss.shrinkwrap.descriptors</groupId>
Review Comment:
Has to be compile time
```
[INFO] 1 error
[INFO] -------------------------------------------------------------
[INFO]
------------------------------------------------------------------------
[INFO] BUILD FAILURE
[INFO]
------------------------------------------------------------------------
[INFO] Total time: 20.275 s
[INFO] Finished at: 2022-05-20T14:30:24-04:00
[INFO]
------------------------------------------------------------------------
[WARNING] The requested profile "install" could not be activated because it
does not exist.
[ERROR] Failed to execute goal
org.apache.maven.plugins:maven-compiler-plugin:3.8.1:compile (default-compile)
on project gateway-provider-identity-assertion-common: Compilation failure
[ERROR]
/knox/gateway-provider-identity-assertion-common/src/main/java/org/apache/knox/gateway/identityasserter/common/filter/AbstractIdentityAsserterDeploymentContributor.java:[89,32]
cannot access org.jboss.shrinkwrap.descriptor.api.webapp30.WebAppDescriptor
[ERROR] class file for
org.jboss.shrinkwrap.descriptor.api.webapp30.WebAppDescriptor not found
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]