zeroflag commented on code in PR #597:
URL: https://github.com/apache/knox/pull/597#discussion_r905828331
##########
gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java:
##########
@@ -58,7 +59,7 @@ public void contributeFilter( DeploymentContext context,
Provider provider, Serv
Map<String, String> providerParams = provider.getParams();
String providerNames = providerParams.get("composite.provider.names");
- if (!providerNames.isEmpty()) {
+ if (!StringUtils.isEmpty(providerNames)) {
Review Comment:
Good job and thank you for the changes @harshiljhaveri. One last thing is
that this conditional seems to be unnecessary. The `parseProviderNames` returns
an empty list if the parameter is blank so the for loop won't do anything in
that case. I would just remove this `if` statement and rely on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
