[
https://issues.apache.org/jira/browse/KNOX-2762?focusedWorklogId=784449&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-784449
]
ASF GitHub Bot logged work on KNOX-2762:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Jun/22 08:12
Start Date: 24/Jun/22 08:12
Worklog Time Spent: 10m
Work Description: zeroflag commented on code in PR #597:
URL: https://github.com/apache/knox/pull/597#discussion_r905828331
##########
gateway-provider-security-authz-composite/src/main/java/org/apache/knox/gateway/deploy/impl/CompositeAuthzDeploymentContributor.java:
##########
@@ -58,7 +59,7 @@ public void contributeFilter( DeploymentContext context,
Provider provider, Serv
Map<String, String> providerParams = provider.getParams();
String providerNames = providerParams.get("composite.provider.names");
- if (!providerNames.isEmpty()) {
+ if (!StringUtils.isEmpty(providerNames)) {
Review Comment:
Good job and thank you for the changes @harshiljhaveri. One last thing is
that this conditional seems to be unnecessary. The `parseProviderNames` returns
an empty list if the parameter is blank so the for loop won't do anything in
that case. I would just remove this `if` statement and rely on that.
Issue Time Tracking
-------------------
Worklog Id: (was: 784449)
Time Spent: 3h 20m (was: 3h 10m)
> Whitespaces around delimiters in composite provider names gives
> NullPointerException
> ------------------------------------------------------------------------------------
>
> Key: KNOX-2762
> URL: https://issues.apache.org/jira/browse/KNOX-2762
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Affects Versions: 1.6.0
> Reporter: Harshil Jhaveri
> Assignee: Harshil Jhaveri
> Priority: Minor
> Fix For: 2.0.0
>
> Attachments: NPE gateway log.png
>
> Time Spent: 3h 20m
> Remaining Estimate: 0h
>
> When giving space before the delimiter for composite.provider.names in
> composite authorisation provider. The topology deployment is failing and
> returning a null pointer exception.
> The topology state:
> {code:java}
> <provider>
> <role>authorization</role>
> <name>CompositeAuthz</name>
> <enabled>true</enabled>
> <param>
> <name>composite.provider.names</name>
> <value>AclsAuthz ,XASecurePDPKnox</value>
> </param>
> <param>
> <name>AclsAuthz.ranger.acl</name>
> <value>*;;</value> </param></provider>
> </provider>{code}
> {color:#e8bf6a}CC:{color} [~pzampino] [~smore] [~smolnar]
--
This message was sent by Atlassian Jira
(v8.20.7#820007)
