[
https://issues.apache.org/jira/browse/KNOX-2772?focusedWorklogId=793266&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-793266
]
ASF GitHub Bot logged work on KNOX-2772:
----------------------------------------
Author: ASF GitHub Bot
Created on: 20/Jul/22 14:01
Start Date: 20/Jul/22 14:01
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #605:
URL: https://github.com/apache/knox/pull/605#discussion_r925644227
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -592,6 +593,11 @@ public List<String> getExcludedSSLCiphers() {
return list;
}
+ @Override
+ public boolean getRenegotiation() {
Review Comment:
Please give a better name for this method. It does not reflect SSL.
Recommended: `isSSLRenegotiationAllowed`.
Thanks!
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -592,6 +593,11 @@ public List<String> getExcludedSSLCiphers() {
return list;
}
+ @Override
+ public boolean getRenegotiation() {
+ return Boolean.parseBoolean(get( SSL_RENEGOTIATION, "false" ));
Review Comment:
We already have a `getBoolean(String name, boolean default)` method. Please
use it.
Issue Time Tracking
-------------------
Worklog Id: (was: 793266)
Time Spent: 0.5h (was: 20m)
> add configuration for jetty renegotiation
> -----------------------------------------
>
> Key: KNOX-2772
> URL: https://issues.apache.org/jira/browse/KNOX-2772
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 1.6.0
> Reporter: nanhuirong
> Priority: Critical
> Attachments: KNOX-2772.patch
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> the user or developer can't config the renegotiation for knox
> *Action plan:*
> set the value when building the SslContextFactory
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
