zeroflag commented on code in PR #615:
URL: https://github.com/apache/knox/pull/615#discussion_r936528737
##########
gateway-service-knoxssout/pom.xml:
##########
@@ -68,5 +68,9 @@
<artifactId>gateway-test-utils</artifactId>
<scope>test</scope>
</dependency>
+ <dependency>
+ <groupId>org.apache.knox</groupId>
Review Comment:
We can solve this by inverting the dependencies. Let's introduce an
interface fo the ConcurrentSessionVerifier and put it under gateway-spi. In
fact the ConcurrentSessionVerifier is already a good interface name, I would
rename the implementation to something like InMemoryConcurrentSessionVerifier.
So the implementation can stay in gateway-server and the interface in
gateway-spi. WebSSOutResource and WebSSOResource only needs to know the
interface and not the implementation. After that we can delete this dependency.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
