[ 
https://issues.apache.org/jira/browse/KNOX-2778?focusedWorklogId=799624&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-799624
 ]

ASF GitHub Bot logged work on KNOX-2778:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Aug/22 07:34
            Start Date: 10/Aug/22 07:34
    Worklog Time Spent: 10m 
      Work Description: MrtnBalazs commented on code in PR #615:
URL: https://github.com/apache/knox/pull/615#discussion_r942117938


##########
gateway-spi/src/main/java/org/apache/knox/gateway/session/control/ConcurrentSessionVerifier.java:
##########
@@ -0,0 +1,28 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *     http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+package org.apache.knox.gateway.session.control;
+
+import org.apache.knox.gateway.services.Service;
+import org.apache.knox.gateway.services.security.token.impl.JWT;
+
+public interface ConcurrentSessionVerifier extends Service {
+  boolean verifySessionForUser(String username, JWT JWToken);

Review Comment:
   Yes, okay.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 799624)
    Time Spent: 4h 20m  (was: 4h 10m)

> Enforce concurrent session limit in KnoxSSO
> -------------------------------------------
>
>                 Key: KNOX-2778
>                 URL: https://issues.apache.org/jira/browse/KNOX-2778
>             Project: Apache Knox
>          Issue Type: Sub-task
>          Components: Server
>    Affects Versions: 2.0.0
>            Reporter: Sandor Molnar
>            Assignee: Balazs Marton
>            Priority: Major
>             Fix For: 2.0.0
>
>          Time Spent: 4h 20m
>  Remaining Estimate: 0h
>
> Once, KNOX-2777 is ready, the next step is to wire that verifier 
> implementation into the KnoxSSO flow such as it throws an authorization error 
> (FORBIDDEN; 403) when a user tries to log in to UIs (both Knox's own UIs or 
> UIs proxied by Knox) but that user exceeds the configured concurrent session 
> limit.
> Basic logout handling should be covered too:
>  * manually clicking on the logout button
>  * subscribing to a session timeout event (you may want to talk to [~smore] 
> about this)



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to