[ 
https://issues.apache.org/jira/browse/KNOX-2789?focusedWorklogId=802821&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-802821
 ]

ASF GitHub Bot logged work on KNOX-2789:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Aug/22 11:55
            Start Date: 23/Aug/22 11:55
    Worklog Time Spent: 10m 
      Work Description: MrtnBalazs commented on code in PR #622:
URL: https://github.com/apache/knox/pull/622#discussion_r952514087


##########
gateway-spi/src/main/java/org/apache/knox/gateway/config/GatewayConfig.java:
##########
@@ -822,7 +822,7 @@ public interface GatewayConfig {
 
   Set<String> getPrivilegedUsers();
 
-  Set<String> getNonPrivilegedUsers();
+  Set<String> getUnlimitedUsers();

Review Comment:
   Okay, it gives a bit more information.





Issue Time Tracking
-------------------

    Worklog Id:     (was: 802821)
    Time Spent: 40m  (was: 0.5h)

> Refine privileged/non-privileged group settings
> -----------------------------------------------
>
>                 Key: KNOX-2789
>                 URL: https://issues.apache.org/jira/browse/KNOX-2789
>             Project: Apache Knox
>          Issue Type: Sub-task
>          Components: Server
>    Affects Versions: 2.0.0
>            Reporter: Sandor Molnar
>            Assignee: Balazs Marton
>            Priority: Major
>             Fix For: 2.0.0
>
>          Time Spent: 40m
>  Remaining Estimate: 0h
>
> Existing group settings should be refined as follows:
>  * instead of having the privileged and non-privileged groups their own 
> configuration, we should only have one config for the privileged users. 
> Additionally, the existing configuration name should be changed to 
> {{gateway.session.verification.privileged.users}}
>  * Currently, if a user is not listed in any of these groups, are allowed to 
> have unlimited sessions. This should be changed: a new config should be 
> introduced called {{gateway.session.verification.unlimited.users}}
>  * each user that is not listed in any of those groups is considered 
> non-privileged and the previously introduced limit should be applied to it
> Additionally, the following configuration names should be updated:
>  * {{gateway.non.privileged.users.concurrent.session.limit}} -> 
> {{gateway.session.verification.non.privileged.user.limit}}
>  * {{gateway.privileged.users.concurrent.session.limit}} -> 
> {{gateway.session.verification.privileged.user.limit}}



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to