zeroflag opened a new pull request, #626:
URL: https://github.com/apache/knox/pull/626
## What changes were proposed in this pull request?
The client name config parameter was handled in an inconsistent manner.
* When it was null we threw an exception saying that this parameter is
mandatory
* However when it was an empty string, we did fallback using the default
client name coming from the provider
I removed the null check so that we use the default in that case too.
## How was this patch tested?
Manually tested with a topology like this:
```xml
<provider>
<role>federation</role>
<name>pac4j</name>
<enabled>true</enabled>
<param>
<name>pac4j.callbackUrl</name>
<value>https://localhost:8443/gateway/knoxsso/api/v1/websso</value>
</param>
<!-- client name is commented out
<param>
<name>clientName</name>
<value>OidcClient</value>
</param>
-->
<param>
<name>oidc.id</name>
<value>....</value>
</param>
<param>
<name>oidc.secret</name>
<value>SECRET</value>
</param>
<param>
<name>oidc.discoveryUri</name>
<value>...</value>
</param>
<param>
<name>oidc.preferredJwsAlgorithm</name>
<value>RS256</value>
</param>
</provider>
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
