[
https://issues.apache.org/jira/browse/KNOX-2806?focusedWorklogId=811494&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-811494
]
ASF GitHub Bot logged work on KNOX-2806:
----------------------------------------
Author: ASF GitHub Bot
Created on: 23/Sep/22 06:24
Start Date: 23/Sep/22 06:24
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #634:
URL: https://github.com/apache/knox/pull/634#discussion_r978299156
##########
gateway-provider-security-dos/pom.xml:
##########
@@ -0,0 +1,24 @@
+<?xml version="1.0" encoding="UTF-8"?>
Review Comment:
Missing Apache license:
```
<!--
Licensed to the Apache Software Foundation (ASF) under one or more
contributor license agreements. See the NOTICE file distributed with
this work for additional information regarding copyright ownership.
The ASF licenses this file to You under the Apache License, Version 2.0
(the "License"); you may not use this file except in compliance with
the License. You may obtain a copy of the License at
http://www.apache.org/licenses/LICENSE-2.0
Unless required by applicable law or agreed to in writing, software
distributed under the License is distributed on an "AS IS" BASIS,
WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
See the License for the specific language governing permissions and
limitations under the License.
-->
```
Issue Time Tracking
-------------------
Worklog Id: (was: 811494)
Time Spent: 40m (was: 0.5h)
> Implement a new DoS security provider
> -------------------------------------
>
> Key: KNOX-2806
> URL: https://issues.apache.org/jira/browse/KNOX-2806
> Project: Apache Knox
> Issue Type: Improvement
> Components: Server
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Balazs Marton
> Priority: Major
> Fix For: 2.0.0
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> There is a need to implement a mechanism that prevents Knox from being
> attacked using DoS (Denial of Service).
> One elegant way is to reuse Jetty's own DoS filter in a way such that it can
> be configured as a new security provider:
> * Maven project name: {{gateway-provider-security-dos}}
> * Provider role: {{dos}}
> * Provider name: {{JettyDoS}}
> In case someone wants to use this new feature, the new provider declaration
> has to be added to the top of the providers (it must be documented). When
> this provider is present in the topology, Jetty's DosFilter has to be
> contributed to the filter chain. That is, a new
> {{ProviderDeploymentContributor}} should be implemented that inserts the
> {{org.eclipse.jetty.servlets.DoSFilter}} into each resource that is available
> in the topology.
> References:
> * [https://www.eclipse.org/jetty/documentation/jetty-9/index.html#dos-filter]
> *
> [https://archive.eclipse.org/jetty/9.0.0.RC0/apidocs/org/eclipse/jetty/servlets/DoSFilter.html]
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
