[
https://issues.apache.org/jira/browse/KNOX-2832?focusedWorklogId=823270&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-823270
]
ASF GitHub Bot logged work on KNOX-2832:
----------------------------------------
Author: ASF GitHub Bot
Created on: 04/Nov/22 06:16
Start Date: 04/Nov/22 06:16
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #668:
URL: https://github.com/apache/knox/pull/668#discussion_r1013657425
##########
gateway-provider-security-webappsec/src/main/java/org/apache/knox/gateway/webappsec/deploy/WebAppSecContributor.java:
##########
@@ -150,12 +165,24 @@ public void contributeFilter(DeploymentContext
context,
}
}
- private void provisionConfig(ResourceDescriptor resource, Map<String,String>
providerParams,
- List<FilterParamDescriptor> params, String prefix) {
- for(Entry<String, String> entry : providerParams.entrySet()) {
+ private void provisionConfig(ResourceDescriptor resource, Map<String,
String> providerParams,
+ List<FilterParamDescriptor> params, String
prefix, boolean cutPrefix, boolean toLowerCase) {
Review Comment:
@lmccay - yes, Jetty's DOS filter is different than the other filters in
this respect. As you can see from the samples Balazs gave us, the parameters in
this filter:
- do not need any special prefix (such as `rate.limiting`)
- they are case sensitive
Issue Time Tracking
-------------------
Worklog Id: (was: 823270)
Time Spent: 0.5h (was: 20m)
> Convert JettyDOS provider to a rate limiting option in webappsec
> ----------------------------------------------------------------
>
> Key: KNOX-2832
> URL: https://issues.apache.org/jira/browse/KNOX-2832
> Project: Apache Knox
> Issue Type: Task
> Components: Server
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Balazs Marton
> Priority: Critical
> Fix For: 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> It'd be better to remove the recently created {{JettyDos}} security provider
> and have it functionality wired into Knox's existing {{webappsec}} provider
> just like other security elements (e.g. XFrame, CORS, XSS,...)
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
