[
https://issues.apache.org/jira/browse/KNOX-2833?focusedWorklogId=825329&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-825329
]
ASF GitHub Bot logged work on KNOX-2833:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Nov/22 14:05
Start Date: 11/Nov/22 14:05
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #672:
URL: https://github.com/apache/knox/pull/672#discussion_r1020240901
##########
gateway-service-definitions/src/main/resources/services/ozone-recon/1.2.0/service.xml:
##########
@@ -0,0 +1,30 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+-->
+<service role="OZONE-RECON" name="ozone-recon" version="1.2.0">
+<metadata>
Review Comment:
Please use indentation here.
##########
gateway-discovery-cm/src/main/resources/META-INF/services/org.apache.knox.gateway.topology.discovery.cm.ServiceModelGenerator:
##########
@@ -54,4 +54,10 @@
org.apache.knox.gateway.topology.discovery.cm.model.nifi.NifiServiceModelGenerat
org.apache.knox.gateway.topology.discovery.cm.model.nifi.NifiRegistryServiceModelGenerator
org.apache.knox.gateway.topology.discovery.cm.model.cm.ClouderaManagerAPIServiceModelGenerator
org.apache.knox.gateway.topology.discovery.cm.model.cm.ClouderaManagerUIServiceModelGenerator
+org.apache.knox.gateway.topology.discovery.cm.model.cruisecontrol.CruiseControlAPIServiceModelGenerator
Review Comment:
We don't have CruiseControlAPI and KafkaConnectAPI support in Apache.
##########
gateway-service-definitions/src/main/resources/services/ozone/1.2.0/service.xml:
##########
@@ -0,0 +1,31 @@
+<!--
+ Licensed to the Apache Software Foundation (ASF) under one or more
+ contributor license agreements. See the NOTICE file distributed with
+ this work for additional information regarding copyright ownership.
+ The ASF licenses this file to You under the Apache License, Version 2.0
+ (the "License"); you may not use this file except in compliance with
+ the License. You may obtain a copy of the License at
+
+ http://www.apache.org/licenses/LICENSE-2.0
+
+ Unless required by applicable law or agreed to in writing, software
+ distributed under the License is distributed on an "AS IS" BASIS,
+ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ See the License for the specific language governing permissions and
+ limitations under the License.
+ -->
+<service role="OZONE" name="ozone" version="1.2.0">
+ <policies>
Review Comment:
AFAIK, the policies section should have been removed from here.
Issue Time Tracking
-------------------
Worklog Id: (was: 825329)
Remaining Estimate: 0h
Time Spent: 10m
> Ozone integration for Apache Knox
> ---------------------------------
>
> Key: KNOX-2833
> URL: https://issues.apache.org/jira/browse/KNOX-2833
> Project: Apache Knox
> Issue Type: Improvement
> Reporter: István Fajth
> Assignee: Debadatta
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> As Ozone is getting more and more use, there is an emerging need to have an
> integration for Ozone.
> The first things we would like to provide is access to Ozone Manager, Storage
> Container Manager and Ozone Recon UI integration.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
