[
https://issues.apache.org/jira/browse/KNOX-2834?focusedWorklogId=828752&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-828752
]
ASF GitHub Bot logged work on KNOX-2834:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Nov/22 15:33
Start Date: 24/Nov/22 15:33
Worklog Time Spent: 10m
Work Description: MrtnBalazs opened a new pull request, #683:
URL: https://github.com/apache/knox/pull/683
## What changes were proposed in this pull request?
The `angular/cli` dependency of all angular applications have been upgraded
to `14.2.8`. Since the projects have been on `1.7.4` (except webshell-ui),
other dependencies, files, configs and some code needed to be changed too.
Main changes:
- changed `TSLint` to `ESLint`
- switched `angular-cli.json` to `angular.json`
- some files were not linted, they are now linted and formatted
- `sweetalert` is changed to `sweetalert2`
- nodejs version is now `v14.15.0`
- commented out xml parsing of shared providers in
`resource-detail.component`
- the div that hosts the topology `ace-editor` is now hidden (it was not
generated before) until it is not needed, so that
it's `ViewChild` can be set.
## How was this patch tested?
I manually tested the features:
Token-management:
- generated normal token
- generated impersonated token
- disabled impersonation
- set server-managed to false
- disabled and revoked the created tokens
Token-generation:
- set server-managed to true and false
- set impersonation to true and false
- set lifespan.input.enabled to true and false
- tried to generate token over the max lifespan limit
- generated tokens until reached token limit
- authenticated with a generated token
Homepage:
- Tried the links
- Mouse on service name -> description shows up
- When UI services are clicked they navigate to UI URL
- When API services are clicked description shows up
- Dropdown menus open and close
- New topologies appear under the topologies menu
Admin-ui:
- Created, deleted, modified service definitions
- Created, deleted, modified provider configuration
- Created, deleted, modified descriptor
- Copied, deleted, modified topology
Issue Time Tracking
-------------------
Worklog Id: (was: 828752)
Remaining Estimate: 0h
Time Spent: 10m
> Take care of existing javascript upgrades by dependabot
> -------------------------------------------------------
>
> Key: KNOX-2834
> URL: https://issues.apache.org/jira/browse/KNOX-2834
> Project: Apache Knox
> Issue Type: Improvement
> Components: AdminUI, Homepage
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Balazs Marton
> Priority: Major
> Fix For: 2.0.0
>
> Attachments: image-2022-11-04-11-12-00-500.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> [~MrtnBalazs] - as discussed offline, there is a list of open PRs generated
> by Apache's dependabot for our javascript-based Maven modules (*-ui) where
> there are some components such as angular-cli that needed to be upgraded to a
> higher version due to security reasons (see attached screenshot).
> Please compile a table with the source/target dependency versions and make
> sure they are all applied in our code base within the scope of this JIRA and
> covered by manual testing as discussed.
>
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
