[
https://issues.apache.org/jira/browse/KNOX-2848?focusedWorklogId=830665&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-830665
]
ASF GitHub Bot logged work on KNOX-2848:
----------------------------------------
Author: ASF GitHub Bot
Created on: 02/Dec/22 15:19
Start Date: 02/Dec/22 15:19
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #687:
URL: https://github.com/apache/knox/pull/687#discussion_r1038248513
##########
gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/TopologiesResource.java:
##########
@@ -424,6 +429,14 @@ public Response uploadSimpleDescriptor(@PathParam("name")
String name,
return response;
}
+ private boolean existingGeneratedTopology(String fileName, TopologyService
topologyService, GatewayConfig config) {
+ for (org.apache.knox.gateway.topology.Topology topology :
topologyService.getTopologies()) {
Review Comment:
I do not see where we check if the given topology is `readOnly`. This
implementation will prevent creating/overwriting all topologies, won't it?
Issue Time Tracking
-------------------
Worklog Id: (was: 830665)
Time Spent: 20m (was: 10m)
> Prevent overwriting generated descriptors/providers
> ----------------------------------------------------
>
> Key: KNOX-2848
> URL: https://issues.apache.org/jira/browse/KNOX-2848
> Project: Apache Knox
> Issue Type: Sub-task
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> One can overwrite a generated descriptor or provider using the admin UI.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
