zeroflag commented on code in PR #687:
URL: https://github.com/apache/knox/pull/687#discussion_r1039663874
##########
gateway-service-admin/src/main/java/org/apache/knox/gateway/service/admin/TopologiesResource.java:
##########
@@ -424,6 +429,14 @@ public Response uploadSimpleDescriptor(@PathParam("name")
String name,
return response;
}
+ private boolean existingGeneratedTopology(String fileName, TopologyService
topologyService, GatewayConfig config) {
+ for (org.apache.knox.gateway.topology.Topology topology :
topologyService.getTopologies()) {
Review Comment:
We check if the topology is included in
`config.getReadOnlyOverrideTopologyNames()`. There is an `isGenerated` flag in
the topology as well, but at this point of the code, it is not yet populated.
Therefore I check directly based on the config property.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
