smolnar82 commented on code in PR #681:
URL: https://github.com/apache/knox/pull/681#discussion_r1053066261
##########
gateway-provider-identity-assertion-common/pom.xml:
##########
@@ -97,7 +97,14 @@
<groupId>org.jboss.shrinkwrap</groupId>
<artifactId>shrinkwrap-api</artifactId>
</dependency>
-
+ <dependency>
+ <groupId>org.apache.hadoop</groupId>
+ <artifactId>hadoop-common</artifactId>
+ </dependency>
+ <dependency>
+ <groupId>com.google.guava</groupId>
+ <artifactId>guava</artifactId>
Review Comment:
hadoop-common is needed due to the newly introduced logic:
AuthoriztionException is thrown in case proxyuser-based impersonation is not
authorized. To mitigate this I'll create our own exception and util classes in
gateway-spi (where we already have everything in place) and propagate/use these
new exception/class down the line.
Guava was added because of the `@VisibleForTesting` annotation which we
really do not need, so I'll remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
