smolnar82 commented on code in PR #706:
URL: https://github.com/apache/knox/pull/706#discussion_r1060716025
##########
knox-webshell-ui/angular.json:
##########
@@ -54,18 +54,8 @@
},
"configurations": {
"production": {
- "budgets": [
- {
- "type": "initial",
- "maximumWarning": "500kb",
- "maximumError": "1mb"
- },
- {
- "type": "anyComponentStyle",
- "maximumWarning": "2kb",
- "maximumError": "4kb"
- }
- ],
+ "buildOptimizer": false,
+ "aot": false,
Review Comment:
We have the same config in AdminUI and TokenManagementUI and there were no
complaints so far about their performance. It's true that we may want AOT to be
turned on, but I think it has to be in the scope of a different JIRA; right now
fixing the build is more important.
What do you think?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
