[
https://issues.apache.org/jira/browse/KNOX-2860?focusedWorklogId=836645&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-836645
]
ASF GitHub Bot logged work on KNOX-2860:
----------------------------------------
Author: ASF GitHub Bot
Created on: 03/Jan/23 15:51
Start Date: 03/Jan/23 15:51
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #706:
URL: https://github.com/apache/knox/pull/706#discussion_r1060716025
##########
knox-webshell-ui/angular.json:
##########
@@ -54,18 +54,8 @@
},
"configurations": {
"production": {
- "budgets": [
- {
- "type": "initial",
- "maximumWarning": "500kb",
- "maximumError": "1mb"
- },
- {
- "type": "anyComponentStyle",
- "maximumWarning": "2kb",
- "maximumError": "4kb"
- }
- ],
+ "buildOptimizer": false,
+ "aot": false,
Review Comment:
We have the same config in AdminUI and TokenManagementUI and there were no
complaints so far about their performance. It's true that we may want AOT to be
turned on, but I think it has to be in the scope of a different JIRA; right now
fixing the build is more important.
What do you think?
Issue Time Tracking
-------------------
Worklog Id: (was: 836645)
Time Spent: 0.5h (was: 20m)
> Cannot build knox-webshell-ui
> -----------------------------
>
> Key: KNOX-2860
> URL: https://issues.apache.org/jira/browse/KNOX-2860
> Project: Apache Knox
> Issue Type: Bug
> Components: WebShell
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Blocker
> Fix For: 2.0.0
>
> Time Spent: 0.5h
> Remaining Estimate: 0h
>
> I've just pulled in all recent changes (including several Angular updates)
> and the {{knox-webshell-ui}} project no longer builds on my machine.
> This is the only UI project that failed to build, the rest of them (AdminUI,
> TokenGenerationUI, TokenManagementUI, and HomePage) were OK.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
