zeroflag commented on code in PR #714:
URL: https://github.com/apache/knox/pull/714#discussion_r1065620201
##########
gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java:
##########
@@ -95,7 +95,7 @@ public class WebSSOResource {
private static final String ORIGINAL_URL_COOKIE_NAME = "original-url";
private static final String DEFAULT_SSO_COOKIE_NAME = "hadoop-jwt";
private static final String SSO_COOKIE_SAMESITE_DEFAULT = "Strict";
- private static final long TOKEN_TTL_DEFAULT = 30000L;
+ private static final long TOKEN_TTL_DEFAULT = 15000 * 60;
Review Comment:
@pzampino Right, this might not be strictly needed. We can modify the
deployment related default configs only.
But I think it shouldn't break anything either. If someone needs a specific
value I would expect them to have an explicit configuration instead of relaying
the default. And the default 30seconds timeout seems to be too low anyway,
isn't it?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
