[ 
https://issues.apache.org/jira/browse/KNOX-2862?focusedWorklogId=838291&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-838291
 ]

ASF GitHub Bot logged work on KNOX-2862:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 10/Jan/23 10:47
            Start Date: 10/Jan/23 10:47
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on code in PR #714:
URL: https://github.com/apache/knox/pull/714#discussion_r1065620201


##########
gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java:
##########
@@ -95,7 +95,7 @@ public class WebSSOResource {
   private static final String ORIGINAL_URL_COOKIE_NAME = "original-url";
   private static final String DEFAULT_SSO_COOKIE_NAME = "hadoop-jwt";
   private static final String SSO_COOKIE_SAMESITE_DEFAULT = "Strict";
-  private static final long TOKEN_TTL_DEFAULT = 30000L;
+  private static final long TOKEN_TTL_DEFAULT = 15000 * 60;

Review Comment:
   @pzampino Right, this might not be strictly needed. We can modify the 
deployment related default configs only. 
   But I think it shouldn't break anything either. If someone needs a specific 
value I would expect them to have an explicit configuration instead of relaying 
the default. And the default 30seconds timeout seems to be too low anyway, 
isn't it?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 838291)
    Time Spent: 0.5h  (was: 20m)

> Setup idle timeout for SSO cookie to 15 minutes
> -----------------------------------------------
>
>                 Key: KNOX-2862
>                 URL: https://issues.apache.org/jira/browse/KNOX-2862
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> Fedramp mandates this to be 15 minutes 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to