[ 
https://issues.apache.org/jira/browse/KNOX-2871?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=17683076#comment-17683076
 ] 

Attila Magyar commented on KNOX-2871:
-------------------------------------

[~pzampino], We gave it a second thought with [~smolnar], and yes the dummy 
discovery type might not be ideal. A better approach seems to be to refine the 
shouldPerformDiscovery check, which currently only takes the discovery type 
into consideration and not the URL. By modifying this conditional to check both 
the type and URL would also solve this issue. Having an empty/null URL would 
mean that discovery is disabled.

> Refine should perform discovery check
> -------------------------------------
>
>                 Key: KNOX-2871
>                 URL: https://issues.apache.org/jira/browse/KNOX-2871
>             Project: Apache Knox
>          Issue Type: Task
>            Reporter: Attila Magyar
>            Assignee: Attila Magyar
>            Priority: Major
>
> Currently if the discovery-type is set to null or an empty string then it 
> will default to "ClouderaManager". If service discovery fails for any reason 
> then the topology is not going to be generated. In some cases the user wants 
> to use static service URLs for the services while also keeping discovery 
> enabled. A dummy service discovery type that always returns an empty service 
> list would make this possible.
> cc.: [~smolnar]



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to