[jira] [Work logged] (KNOX-2890) When client-knox connection is broken knox should not retry the same client request

[ASF GitHub Bot (Jira)]

     [ 
https://issues.apache.org/jira/browse/KNOX-2890?focusedWorklogId=852588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-852588
 ]

ASF GitHub Bot logged work on KNOX-2890:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 23/Mar/23 15:03
            Start Date: 23/Mar/23 15:03
    Worklog Time Spent: 10m 
      Work Description: zeroflag commented on code in PR #742:
URL: https://github.com/apache/knox/pull/742#discussion_r1146336678


##########
gateway-provider-ha/src/main/java/org/apache/knox/gateway/ha/dispatch/ConfigurableHADispatch.java:
##########
@@ -61,18 +61,20 @@ public class ConfigurableHADispatch extends 
ConfigurableDispatch {
 
   protected static final HaDispatchMessages LOG = 
MessagesFactory.get(HaDispatchMessages.class);
 
-  private int maxFailoverAttempts = 
HaServiceConfigConstants.DEFAULT_MAX_FAILOVER_ATTEMPTS;
+  protected int maxFailoverAttempts = 
HaServiceConfigConstants.DEFAULT_MAX_FAILOVER_ATTEMPTS;
 
-  private int failoverSleep = HaServiceConfigConstants.DEFAULT_FAILOVER_SLEEP;
+  protected int failoverSleep = 
HaServiceConfigConstants.DEFAULT_FAILOVER_SLEEP;
 
-  private HaProvider haProvider;
+  protected HaProvider haProvider;
 
   private static final Map<String, String> urlToHashLookup = new HashMap<>();
   private static final Map<String, String> hashToUrlLookup = new HashMap<>();
+  protected static final List<String> idempotentRequests = 
Arrays.asList("POST", "PATCH", "CONNECT");

Review Comment:
   Aren't these the `non` idempotent requests?





Issue Time Tracking
-------------------

    Worklog Id:     (was: 852588)
    Time Spent: 20m  (was: 10m)

> When client-knox connection is broken knox should not retry the same client 
> request
> -----------------------------------------------------------------------------------
>
>                 Key: KNOX-2890
>                 URL: https://issues.apache.org/jira/browse/KNOX-2890
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>    Affects Versions: 2.0..0
>            Reporter: J.Andreina
>            Assignee: Sandeep More
>            Priority: Major
>          Time Spent: 20m
>  Remaining Estimate: 0h
>
> Knox should not be retrying non idempotent requests like POST, PATCH etc.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)