[
https://issues.apache.org/jira/browse/KNOX-2894?focusedWorklogId=853588&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-853588
]
ASF GitHub Bot logged work on KNOX-2894:
----------------------------------------
Author: ASF GitHub Bot
Created on: 29/Mar/23 07:24
Start Date: 29/Mar/23 07:24
Worklog Time Spent: 10m
Work Description: zeroflag opened a new pull request, #745:
URL: https://github.com/apache/knox/pull/745
## What changes were proposed in this pull request?
NullPointerException is thrown when the referenced provider is invalid in a
composite provider.
```
<provider>
<role>authorization</role>
<name>CompositeAuthz</name>
<enabled>true</enabled>
<param>
<name>composite.provider.names</name>
<value>x</value>
</param>
</provider>
```
## How was this patch tested?
Manually:
```
2023-03-29 10:19:20,541 ERROR knox.gateway
(DeploymentFactory.java:contributeServices(514)) - Failed to contribute service
[role=WEBHDFS, name=null]: org.apache.knox.gateway.deploy.DeploymentException:
Invalid composite provider name: x role: authorization provider: CompositeAuthz
topology: sandbox
org.apache.knox.gateway.deploy.DeploymentException: Invalid composite
provider name: x role: authorization provider: CompositeAuthz topology: sandbox
at
org.apache.knox.gateway.deploy.impl.CompositeAuthzDeploymentContributor.contributeFilter(CompositeAuthzDeploymentContributor.java:71)
~[gateway-provider-security-authz-composite-2.1.0-SNAPSHOT.jar:2.1.0-SNAPSHOT]
````
Issue Time Tracking
-------------------
Worklog Id: (was: 853588)
Remaining Estimate: 0h
Time Spent: 10m
> NPE when invalid composite provider name is given
> -------------------------------------------------
>
> Key: KNOX-2894
> URL: https://issues.apache.org/jira/browse/KNOX-2894
> Project: Apache Knox
> Issue Type: Bug
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> <provider>
> <role>authorization</role>
> <name>CompositeAuthz</name>
> <enabled>true</enabled>
> <param>
> <name>composite.provider.names</name>
> <value>x</value>
> </param>
> </provider>
> {code}
> 2023-03-28 14:17:19,222 ERROR knox.gateway
> (DeploymentFactory.java:contributeServices(522)) - Failed to contribute
> service [role=CM-API, name=null]: java.lang.NullPointerException
> java.lang.NullPointerException: null
> at
> org.apache.knox.gateway.deploy.impl.CompositeAuthzDeploymentContributor.contributeFilter(CompositeAuthzDeploymentContributor.java:71)
> ~[gateway-provider-security-authz-composite.jar:1.3.0.7.2.17.0-178]
> at
> org.apache.knox.gateway.deploy.DeploymentContextImpl.contributeFilter(DeploymentContextImpl.java:125)
> ~[gateway-server-1.3.0.7.2.17.0-178.jar:1.3.0.7.2.17.0-178]
> at
> org.apache.knox.gateway.deploy.ServiceDeploymentContributorBase.addAuthorizationFilter(ServiceDeploymentContributorBase.java:91)
> ~[gateway-spi-1.3.0.7.2.17.0-178.jar:1.3.0.7.2.17.0-178]
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
