[
https://issues.apache.org/jira/browse/KNOX-2901?focusedWorklogId=858891&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-858891
]
ASF GitHub Bot logged work on KNOX-2901:
----------------------------------------
Author: ASF GitHub Bot
Created on: 25/Apr/23 10:19
Start Date: 25/Apr/23 10:19
Worklog Time Spent: 10m
Work Description: smolnar82 commented on code in PR #750:
URL: https://github.com/apache/knox/pull/750#discussion_r1176307405
##########
gateway-topology-hadoop-xml/src/main/java/org/apache/knox/gateway/topology/hadoop/xml/HadoopXmlResourceParser.java:
##########
@@ -70,6 +71,7 @@ public class HadoopXmlResourceParser implements
AdvancedServiceDiscoveryConfigCh
private static final String CONFIG_NAME_APPLICATION_PREFIX = "app";
private static final String CONFIG_NAME_SERVICE_URL = "url";
private static final String CONFIG_NAME_SERVICE_VERSION = "version";
+ public static final String REMOVE = "remove";
Review Comment:
We already have a constant for `remove` (see
`CONFIG_NAME_PROVIDER_CONFIGS_PARAM_REMOVE` above). We may remove that one and
use this new, more generic, contact name
Issue Time Tracking
-------------------
Worklog Id: (was: 858891)
Time Spent: 40m (was: 0.5h)
> Deleting a descriptor/provider from hadoop xml resource
> -------------------------------------------------------
>
> Key: KNOX-2901
> URL: https://issues.apache.org/jira/browse/KNOX-2901
> Project: Apache Knox
> Issue Type: Task
> Reporter: Attila Magyar
> Assignee: Attila Magyar
> Priority: Major
> Attachments: Screenshot 2023-04-19 at 13.23.04.png
>
> Time Spent: 40m
> Remaining Estimate: 0h
>
> Currently one can only delete provider config parameters using the following
> syntax:
> {code}
> authentication.param.remove=main.pamRealm.service
> {code}
> But there is no way to remove an entire provider or descriptor.
> Proposed syntax:
> !Screenshot 2023-04-19 at 13.23.04.png!
--
This message was sent by Atlassian Jira
(v8.20.10#820010)