moresandeep commented on PR #752:
URL: https://github.com/apache/knox/pull/752#issuecomment-1525475990

   > Hey @moresandeep !
   > 
   > Please forgive me for my dummy question(s), but there is something I'd 
like to clarify: in the current `failoverRequest` method, there are other 
actions in terms of URL-management such as `setupUrlHashLookup` and 
`activeURL.set(outboundRequest.getURI().toString())`. Aren't they required 
along with the new `markEndpointFailed`?
   
   Thank you for checking @smolnar82! I was debating whether to include them 
since we did not actually failover. But, reading your comments and the code 
again, we should be including it! I will update it.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to