[ 
https://issues.apache.org/jira/browse/KNOX-2904?focusedWorklogId=859387&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-859387
 ]

ASF GitHub Bot logged work on KNOX-2904:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 27/Apr/23 10:57
            Start Date: 27/Apr/23 10:57
    Worklog Time Spent: 10m 
      Work Description: moresandeep commented on PR #752:
URL: https://github.com/apache/knox/pull/752#issuecomment-1525475990

   > Hey @moresandeep !
   > 
   > Please forgive me for my dummy question(s), but there is something I'd 
like to clarify: in the current `failoverRequest` method, there are other 
actions in terms of URL-management such as `setupUrlHashLookup` and 
`activeURL.set(outboundRequest.getURI().toString())`. Aren't they required 
along with the new `markEndpointFailed`?
   
   Thank you for checking @smolnar82! I was debating whether to include them 
since we did not actually failover. But, reading your comments and the code 
again, we should be including it! I will update it.




Issue Time Tracking
-------------------

    Worklog Id:     (was: 859387)
    Time Spent: 0.5h  (was: 20m)

> Endpoint is not marked as failed in case of non-idempotent request failover
> ---------------------------------------------------------------------------
>
>                 Key: KNOX-2904
>                 URL: https://issues.apache.org/jira/browse/KNOX-2904
>             Project: Apache Knox
>          Issue Type: Bug
>          Components: Server
>            Reporter: Sandeep More
>            Assignee: Sandeep More
>            Priority: Major
>          Time Spent: 0.5h
>  Remaining Estimate: 0h
>
> When a non-idempotent request fails the endpoint is not marked as failed. 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to