[ 
https://issues.apache.org/jira/browse/KNOX-2953?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
 ]

liang.feng updated KNOX-2953:
-----------------------------
    Status: Patch Available  (was: Open)

[PR789|https://github.com/apache/knox/pull/789]

> Uniform name of http method of client metric to lowerCase
> ---------------------------------------------------------
>
>                 Key: KNOX-2953
>                 URL: https://issues.apache.org/jira/browse/KNOX-2953
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: Metrics
>            Reporter: liang.feng
>            Priority: Minor
>         Attachments: gateway-client-metric.png
>
>
> The metric name starting with client should set httpMethod to lowercase, when 
> build metric name, just like the service metric name at [#
> https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/metrics/impl/instr/InstrHttpClientBuilderProvider.java#L68]
>  
> There are many similar metric names now,due to name of httpMethod is 
> non-uniform. 
> For example:
> When I query from HBase with curl command , The command curl -X Get 和 curl -X 
> GET will generate two similar metric name
> !gateway-client-metric.png!
>  
> We should uniformly change the method name to lowercase  so that the metric 
> names of service and client are unified



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to