[
https://issues.apache.org/jira/browse/KNOX-2957?focusedWorklogId=880262&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-880262
]
ASF GitHub Bot logged work on KNOX-2957:
----------------------------------------
Author: ASF GitHub Bot
Created on: 13/Sep/23 20:01
Start Date: 13/Sep/23 20:01
Worklog Time Spent: 10m
Work Description: risdenk commented on code in PR #794:
URL: https://github.com/apache/knox/pull/794#discussion_r1325017580
##########
build-tools/src/main/resources/build-tools/spotbugs-filter.xml:
##########
@@ -90,4 +90,14 @@ limitations under the License.
<Class
name="org.apache.knox.gateway.audit.log4j.correlation.Log4jCorrelationService"
/>
<Bug pattern="OBJECT_DESERIALIZATION" />
</Match>
+
+ <Match>
+ <Class
name="org.apache.knox.gateway.services.security.impl.ConfigurableEncryptor" />
+ <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
Review Comment:
I think this is a real finding.
https://github.com/apache/knox/blob/master/gateway-spi/src/main/java/org/apache/knox/gateway/services/security/impl/ConfigurableEncryptor.java#L106
that random could be created once instead of every time for encrypting bytes.
##########
build-tools/src/main/resources/build-tools/spotbugs-filter.xml:
##########
@@ -90,4 +90,14 @@ limitations under the License.
<Class
name="org.apache.knox.gateway.audit.log4j.correlation.Log4jCorrelationService"
/>
<Bug pattern="OBJECT_DESERIALIZATION" />
</Match>
+
+ <Match>
+ <Class
name="org.apache.knox.gateway.services.security.impl.ConfigurableEncryptor" />
+ <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
+ </Match>
+
+ <Match>
+ <Class
name="org.apache.knox.gateway.services.registry.impl.DefaultServiceRegistryService"
/>
+ <Bug pattern="DMI_RANDOM_USED_ONLY_ONCE" />
Review Comment:
I think this is also a real finding -
https://github.com/apache/knox/blob/master/gateway-server/src/main/java/org/apache/knox/gateway/services/registry/impl/DefaultServiceRegistryService.java#L74
Issue Time Tracking
-------------------
Worklog Id: (was: 880262)
Time Spent: 20m (was: 10m)
> Upgrade Groovy version >= 3.0.8 to support knoxshell on JDK17 cluster
> ---------------------------------------------------------------------
>
> Key: KNOX-2957
> URL: https://issues.apache.org/jira/browse/KNOX-2957
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 20m
> Remaining Estimate: 0h
>
> Execution on knoxshell.sh fails on jdk17 with below error
> {code:java}
> Caught: BUG! exception in phase 'semantic analysis' in source unit
> '/tmp/tokenShell/webHdfsLs.groovy' Unsupported class file major version 61
> BUG! exception in phase 'semantic analysis' in source unit
> '/tmp/tokenShell/webHdfsLs.groovy' Unsupported class file major version 61
> at org.apache.knox.gateway.shell.Shell.main(Shell.java:70)
> at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native
> Method)
> at
> java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:77)
> at
> java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> at
> org.apache.knox.gateway.launcher.Invoker.invokeMainMethod(Invoker.java:68)
> at org.apache.knox.gateway.launcher.Invoker.invoke(Invoker.java:39)
> at org.apache.knox.gateway.launcher.Command.run(Command.java:99)
> at org.apache.knox.gateway.launcher.Launcher.run(Launcher.java:75)
> at org.apache.knox.gateway.launcher.Launcher.main(Launcher.java:52)
> Caused by: java.lang.IllegalArgumentException: Unsupported class file major
> version 61
> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:189)
> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:170)
> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:156)
> at groovyjarjarasm.asm.ClassReader.<init>(ClassReader.java:277)
> ... 9 more
> {code}
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
