smolnar82 commented on code in PR #799:
URL: https://github.com/apache/knox/pull/799#discussion_r1350062548


##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -452,8 +459,11 @@ public Response getUserTokens(@Context UriInfo uriInfo) {
       final String userName = 
uriInfo.getQueryParameters().getFirst("userName");
       final String createdBy = 
uriInfo.getQueryParameters().getFirst("createdBy");
       final String userNameOrCreatedBy = 
uriInfo.getQueryParameters().getFirst("userNameOrCreatedBy");
+      final boolean allTokens = 
Boolean.parseBoolean(uriInfo.getQueryParameters().getFirst("allTokens"));

Review Comment:
   ```
   $ curl -iku admin:admin-password -X GET 
https://localhost:8443/gateway/sandbox/knoxtoken/api/v1/token/getUserTokens
   HTTP/1.1 200 OK
   Date: Mon, 09 Oct 2023 09:25:28 GMT
   Set-Cookie: KNOXSESSIONID=node01gkirc5lmzq5p12xm4l9mkip390.node0; 
Path=/gateway/sandbox; Secure; HttpOnly
   Expires: Thu, 01 Jan 1970 00:00:00 GMT
   Set-Cookie: rememberMe=deleteMe; Path=/gateway/sandbox; Max-Age=0; 
Expires=Sun, 08-Oct-2023 09:25:28 GMT; SameSite=lax
   Content-Type: application/json
   Content-Length: 13
   
   {"tokens":[]}
   ```
   In gateway.log:
   ```
   2023-10-09 11:25:29,822 84376fc3-8a56-42f3-a399-9f81f0ffe2da ERROR 
token.state (JDBCTokenStateService.java:getTokens(312)) - An error occurred 
while fetching tokens for user null from the database : No value specified for 
parameter 1.
   ```
   This is handled.



##########
gateway-service-knoxtoken/src/main/java/org/apache/knox/gateway/service/knoxtoken/TokenResource.java:
##########
@@ -559,6 +569,22 @@ public Response renew(String token) {
     return resp;
   }
 
+  @DELETE
+  @Path(BATCH_REVOKE_PATH)
+  @Produces({APPLICATION_JSON})
+  public Response revokeTokens(String tokenIds) {
+    final List<String> ids = GSON.fromJson(tokenIds, List.class);

Review Comment:
   I thought the same way, however, I could not make it work this way:
   ```
     @DELETE
     @Path(BATCH_REVOKE_PATH)
     @Produces({APPLICATION_JSON})
     @Consumes(APPLICATION_JSON)
     public Response revokeTokens(List<String> tokenIds) {
     }
   ```
   I always received 415 (Unsupported Media Type) every time no matter what I 
tried (added the required headers in the `curl` command).



##########
knox-token-management-ui/token-management/app/knox.token.ts:
##########
@@ -25,4 +25,8 @@ export class KnoxToken {
     expirationLong: number;
     maxLifetime: string;
     metadata: Metadata;
+
+    public toString = (): string => {
+        return `KnoxToken (tokenId: ${this.tokenId})`;

Review Comment:
   Hm...that's wrong. Let me fix that.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]

Reply via email to