[ 
https://issues.apache.org/jira/browse/KNOX-2970?focusedWorklogId=886129&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886129
 ]

ASF GitHub Bot logged work on KNOX-2970:
----------------------------------------

                Author: ASF GitHub Bot
            Created on: 19/Oct/23 13:19
            Start Date: 19/Oct/23 13:19
    Worklog Time Spent: 10m 
      Work Description: smolnar82 opened a new pull request, #806:
URL: https://github.com/apache/knox/pull/806

   ## What changes were proposed in this pull request?
   
   When end-users log out from the application (using the logout button on the 
Knox Home page), the KnoxSSO cookie is removed from the token state service too 
(if it was configured earlier).
   I also made a small, but useful change on the Token Management UI: `current` 
KnoxSSO cookie, bound to the current session, is shown in **bold**.
   
   ## How was this patch tested?
   
   Manual testing:
   1. enabled logout on Knox Home page
   1. enabled the storage of KnoxSSO cookies
   1. logged into the Knox Token Management page in a regular browser window
   2. logged into the Knox Token Management page in an incognito browser window
   3. logged out from the Knox Home page in the incognito window
   4. logged in again in the incognito window
   
   Before logout:
   
   <img width="1780" alt="Screenshot 2023-10-19 at 14 58 28" 
src="https://github.com/apache/knox/assets/34065904/5800af37-6c52-4a47-85c9-2636ad3f14b9";>
   
   <img width="1785" alt="Screenshot 2023-10-19 at 14 58 41" 
src="https://github.com/apache/knox/assets/34065904/a8e60ec3-46ed-4af6-b845-3498126a9276";>
   
   
   After logout and re-login:
   
   <img width="1769" alt="Screenshot 2023-10-19 at 14 59 15" 
src="https://github.com/apache/knox/assets/34065904/9a515ed5-73cb-4f49-914a-81c8680065a4";>
   
   <img width="1781" alt="Screenshot 2023-10-19 at 14 59 45" 
src="https://github.com/apache/knox/assets/34065904/50d47006-567a-4138-8aa3-ae99a6957b61";>
   
   Relevant log entry:
   ```
   2023-10-19 14:57:53,490 a84e9e8f-7a8f-4ba5-91d1-86d05e587a71 INFO  
service.knoxsso (WebSSOResource.java:saveToken(453)) - Knox Token service 
(knoxsso) stored state for token eyJraW...EG-3Ug (4e58e7fd...943d4023c4f3)
   ...
   2023-10-19 14:58:50,251 a9e1b9e1-cc32-456b-a489-ab9379d636b5 INFO  
service.knoxsso (WebSSOutResource.java:removeKnoxSsoCookie(143)) - Knox Token 
service (homepage) revoked token eyJraW...EG-3Ug (4e58e7fd...943d4023c4f3) 
(renewer=admin)
   ...
   2023-10-19 14:59:02,758 5b8eef40-a408-41d9-99ec-cd150c852748 INFO  
service.knoxsso (WebSSOResource.java:saveToken(453)) - Knox Token service 
(knoxsso) stored state for token eyJraW...a4Kc7Q (663e56bb...918736ba130b)
   ```
   
   




Issue Time Tracking
-------------------

            Worklog Id:     (was: 886129)
    Remaining Estimate: 0h
            Time Spent: 10m

> During knox global logout , the corresponding SSO token should be either 
> disabled or revoked 
> ---------------------------------------------------------------------------------------------
>
>                 Key: KNOX-2970
>                 URL: https://issues.apache.org/jira/browse/KNOX-2970
>             Project: Apache Knox
>          Issue Type: Improvement
>          Components: KnoxSSO
>    Affects Versions: 2.0.0
>            Reporter: J.Andreina
>            Assignee: Sandor Molnar
>            Priority: Major
>          Time Spent: 10m
>  Remaining Estimate: 0h
>
> +*{color:#de350b}PROBLEM STATEMENT:{color}*+
> During knox global logout , SSO token should be either disabled or removed 
> +*BUILDS:*+
> 2.0
>  
> +*STEPS TO REPRODUCE:*+
>  - Enable logout "knox.homepage.logout.enabled" , configure 
> "knox.global.logout.page.url" to "https://*********";
>  - Access knox home page
>  - Click on global logout
> +*CURRENT BEHAVIOUR:*+
> the session will be removed  and user if need to access knox home page again 
> should relogin , but still the previous SSO token will be alive for default 1 
> day which can cause security risk
> +*EXPECTED BEHAVIOUR:*+
> During knox global logout , the corresponding SSO token should be either 
> disabled or revoked 



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to