smolnar82 commented on code in PR #808:
URL: https://github.com/apache/knox/pull/808#discussion_r1367024906
##########
gateway-service-session/src/main/java/org/apache/knox/gateway/service/session/SessionResource.java:
##########
@@ -66,15 +73,23 @@ public SessionInformation getSessionInformation() {
}
private String getBaseGatewayUrl(GatewayConfig config) {
- return request.getRequestURL().substring(0,
- request.getRequestURL().length() - request.getRequestURI().length()) +
- "/" + config.getGatewayPath();
+ return request.getRequestURL().substring(0,
request.getRequestURL().length() - request.getRequestURI().length()) + "/" +
config.getGatewayPath();
}
- private String getLogoutPageUrl(GatewayConfig config) {
- return getBaseGatewayUrl(config) +
- "/knoxsso/knoxauth/logout.jsp?originalUrl=" +
getBaseGatewayUrl(config) +
- "/homepage/home";
+ private String getLogoutPageUrl(GatewayConfig config, String
logoutPageProfile, String logoutPageTopologies) {
+ if (baseLogoutPageUrl == null) {
+ baseLogoutPageUrl = getBaseGatewayUrl(config) +
"/knoxsso/knoxauth/logout.jsp?originalUrl=" + getBaseGatewayUrl(config) +
"/homepage/home";
Review Comment:
It's always fixed; I just made sure not to re-calculate this string every
time. Nothing changed since previous versions.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
