[
https://issues.apache.org/jira/browse/KNOX-2973?focusedWorklogId=886925&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-886925
]
ASF GitHub Bot logged work on KNOX-2973:
----------------------------------------
Author: ASF GitHub Bot
Created on: 24/Oct/23 10:26
Start Date: 24/Oct/23 10:26
Worklog Time Spent: 10m
Work Description: moresandeep opened a new pull request, #809:
URL: https://github.com/apache/knox/pull/809
## What changes were proposed in this pull request?
Fix redirect URI when host and port are query params of originalUrl
## How was this patch tested?
This patch was tested locally and on an cluster with SAML.
Issue Time Tracking
-------------------
Worklog Id: (was: 886925)
Remaining Estimate: 0h
Time Spent: 10m
> HbaseUI>Table Details not accessible from Knox endpoint intermittently
> ----------------------------------------------------------------------
>
> Key: KNOX-2973
> URL: https://issues.apache.org/jira/browse/KNOX-2973
> Project: Apache Knox
> Issue Type: Bug
> Components: Server
> Reporter: Sandeep More
> Assignee: Sandeep More
> Priority: Major
> Time Spent: 10m
> Remaining Estimate: 0h
>
> This is due to the [SSO logic that checks for
> originalURL|https://github.com/apache/knox/blob/master/gateway-service-knoxsso/src/main/java/org/apache/knox/gateway/service/knoxsso/WebSSOResource.java#L365]
> query param.
> During the first login, this is the redirect URL:
> https://local.site/gateway/knoxsso/api/v1/websso?originalUrl=https://local.site/gateway/proxy/hbase/webui/master?host=local.site&port=16010
> When this reaches WebSSOResource.getOriginalUrlFromQueryParams()
> functionvalue of request.getParameter(ORIGINAL_URL_REQUEST_PARAM) is
> https://local.site/gateway/proxy/hbase/webui/master?host=local.site
> Note: port information is missing. This is because of the & query param which
> treats port as a separate param and not part of original URL.
> Also, because of the same reason '?' is added after the host, this is where
> it is done
> This is why additional ? gets added.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
