[
https://issues.apache.org/jira/browse/KNOX-2979?focusedWorklogId=888080&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-888080
]
ASF GitHub Bot logged work on KNOX-2979:
----------------------------------------
Author: ASF GitHub Bot
Created on: 31/Oct/23 13:26
Start Date: 31/Oct/23 13:26
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request, #815:
URL: https://github.com/apache/knox/pull/815
## What changes were proposed in this pull request?
The redundant `refresh` query parameter is no longer added at the tail of
the application logout link on Knox's logout page.
## How was this patch tested?
Manually tested with and without the `logoutProfile` and `logoutTopologies`
session resource attributes.
<img width="1693" alt="Screenshot 2023-10-31 at 14 25 14"
src="https://github.com/apache/knox/assets/34065904/283085df-5c2c-44c6-8a8e-b71c21e0f63c">
<img width="1658" alt="Screenshot 2023-10-31 at 14 25 23"
src="https://github.com/apache/knox/assets/34065904/6e0ec23c-bde8-483d-a557-2566b6a8c732">
<img width="1770" alt="Screenshot 2023-10-31 at 14 25 44"
src="https://github.com/apache/knox/assets/34065904/12ed1705-3b45-4db1-a84f-3b3100470a6b">
Issue Time Tracking
-------------------
Worklog Id: (was: 888080)
Remaining Estimate: 0h
Time Spent: 10m
> Remove redundant 'refresh' query parameter from logout.jsp
> ----------------------------------------------------------
>
> Key: KNOX-2979
> URL: https://issues.apache.org/jira/browse/KNOX-2979
> Project: Apache Knox
> Issue Type: Task
> Components: Homepage, KnoxSSO
> Affects Versions: 2.0.0, 1.6.0, 1.6.1
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Critical
> Fix For: 2.1.0
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> KNOX-2625 introduced a new query parameter called {{refresh}} which is only
> used in the Knox Home page UI's {{handleError}} method. Because of the way,
> how Angular renders pages after issuing a {{sweetalert}} notification, which
> we do, followed by a {{{}Promise.reject(String){}}}, the {{refresh}} query
> parameter is redundant and not needed at all.
> Even worse, it might interfere with the profile/topology query parameters we
> added in KNOX-2972 in a way such that the topologies will not be displayed.
> Therefore, removing the {{refresh}} query parameter in the logout link is
> highly recommended.
--
This message was sent by Atlassian Jira
(v8.20.10#820010)