upczsh commented on code in PR #830: URL: https://github.com/apache/knox/pull/830#discussion_r1438057404
########## gateway-service-definitions/src/main/resources/services/kafkaui.1.0.0/service.xml: ########## @@ -0,0 +1,40 @@ +<?xml version="1.0" encoding="UTF-8" standalone="yes"?> +<!-- + Licensed to the Apache Software Foundation (ASF) under one or more + contributor license agreements. See the NOTICE file distributed with + this work for additional information regarding copyright ownership. + The ASF licenses this file to You under the Apache License, Version 2.0 + (the "License"); you may not use this file except in compliance with + the License. You may obtain a copy of the License at + + http://www.apache.org/licenses/LICENSE-2.0 + + Unless required by applicable law or agreed to in writing, software + distributed under the License is distributed on an "AS IS" BASIS, + WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + See the License for the specific language governing permissions and + limitations under the License. +--> +<service role="KAFKAUI" name="kafkaui" version="1.0.0"> + <metadata> + <type>UI</type> + <context>/kafka/</context> + <shortDesc>kafka Web UI</shortDesc> + <description></description> + </metadata> + <routes> + <route path="/kafka/"> + </route> + <route path="/kafka/**"> + </route> + <route path="/kafka/**?**"> + </route> + </routes> + <dispatch classname="org.apache.knox.gateway.dispatch.ConfigurableDispatch" + ha-classname="org.apache.knox.gateway.ha.dispatch.ConfigurableHADispatch"> + <param> + <name>responseExcludeHeaders</name> + <value>WWW-AUTHENTICATE</value> + </param> Review Comment: Thank you for your guidance, lmccay. I use Knox with LDAP users logging in through Knox SSO. Since Kafka does not support Kerberos authentication and is a simple UI proxy, I did not notice any impact of excluding the WWW-AUTHENTICATE content. In the early stages, when writing the service.xml, I referred to the approach of Ranger UI, which interfaces with Knox SSO instead of communicating with Knox backend through Kerberos. Ranger UI includes the exclusion of WWW-AUTHENTICATE content, and I forgot to remove it when developing Kafka UI. This is my oversight, and I apologize for it. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
