zeroflag commented on code in PR #833:
URL: https://github.com/apache/knox/pull/833#discussion_r1455538074
##########
gateway-server/src/main/java/org/apache/knox/gateway/config/impl/GatewayConfigImpl.java:
##########
@@ -287,6 +287,13 @@ public class GatewayConfigImpl extends Configuration
implements GatewayConfig {
private static final String
CLOUDERA_MANAGER_ADVANCED_SERVICE_DISCOVERY_CONF_MONITOR_INTERVAL =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.advanced.service.discovery.config.monitor.interval";
private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_REPOSITORY_CACHE_ENTRY_TTL =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.repository.cache.entry.ttl";
private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_MAX_RETRY_ATTEMPS =
GATEWAY_CONFIG_FILE_PREFIX +
".cloudera.manager.service.discovery.maximum.retry.attemps";
+ private static final String
CLOUDERA_MANAGER_SERVICE_DISCOVERY_CONNECT_TIMEOUT = GATEWAY_CONFIG_FILE_PREFIX
+ ".cloudera.manager.service.discovery.connect.timeout.msec";
Review Comment:
I like that it's self-documenting so users don't need to check the unit
every time they change it. I can change it to `ms` if it makes more sense.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
