zeroflag commented on code in PR #842:
URL: https://github.com/apache/knox/pull/842#discussion_r1502803074
##########
gateway-service-metadata/src/main/java/org/apache/knox/gateway/service/metadata/KnoxMetadataResource.java:
##########
@@ -101,6 +103,7 @@ public GeneralProxyInformation getGeneralProxyInformation()
{
final ServerInfoService serviceInfoService =
gatewayServices.getService(ServiceType.SERVER_INFO_SERVICE);
final String versionInfo = serviceInfoService.getBuildVersion() + "
(hash=" + serviceInfoService.getBuildHash() + ")";
proxyInfo.setVersion(versionInfo);
+ proxyInfo.setHostname(Hostname.getHostname());
Review Comment:
We've been already using `InetAddress.getLocalHost().getHostName()` and
`InetAddress.getLocalHost().getCanonicalHostName()` at a couple of places in
the project.
I wonder how critical is to have the real hostname in cases like this. If
this is better we might need to consider replacing the existing references to
these `InetAddress` calls.
Otherwise if this is just a nice to have information, we might need to
think about using the existing idom, instead of introducing a new dependency.
Since adding a new dependency is always a liability, for future maintenance
and possible CVE point of view.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org
For queries about this service, please contact Infrastructure at:
us...@infra.apache.org
