[
https://issues.apache.org/jira/browse/KNOX-3017?focusedWorklogId=909196&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-909196
]
ASF GitHub Bot logged work on KNOX-3017:
----------------------------------------
Author: ASF GitHub Bot
Created on: 11/Mar/24 13:13
Start Date: 11/Mar/24 13:13
Worklog Time Spent: 10m
Work Description: smolnar82 opened a new pull request, #877:
URL: https://github.com/apache/knox/pull/877
## What changes were proposed in this pull request?
Two changes on the `Token Generation UI`:
- if the `homepage` topology is configured with `Unlimited token lifetime`,
the lifetime adjustment popup will not shown. The logic was there before, this
was a casting issue between strings and numbers in the JS code.
- added an `exclamation` icon to better emphasize the `Unlimited lifetime`
setting on the UI.
## How was this patch tested?
Manually tested and confirmed that the popup is no longer displayed when
creating a 1-year token with `Unlimited lifetime` settings. The new exclamation
mark is shown as expected (tested with and without the `-1` TTL).
<img width="1747" alt="Screenshot 2024-03-11 at 14 13 13"
src="https://github.com/apache/knox/assets/34065904/79a33228-617b-4afe-9503-590112b98e83";>
Issue Time Tracking
-------------------
Worklog Id: (was: 909196)
Remaining Estimate: 0h
Time Spent: 10m
> Unlimited token generation - invalid warning poopup
> ---------------------------------------------------
>
> Key: KNOX-3017
> URL: https://issues.apache.org/jira/browse/KNOX-3017
> Project: Apache Knox
> Issue Type: Bug
> Affects Versions: 2.0.0
> Reporter: Sandor Molnar
> Assignee: Sandor Molnar
> Priority: Major
> Fix For: 2.1.0
>
> Attachments: Screenshot 2024-03-11 at 12.57.12.png, Screenshot
> 2024-03-11 at 12.57.35.png
>
> Time Spent: 10m
> Remaining Estimate: 0h
>
> *Steps to reproduce*
> * set the {{knox.token.ttl}} to {{-1}} in the {{homepage}} topology for the
> {{KNOXTOKEN}} service
> * go to the {{Token Generation UI}} and set the {{Lifetime}} to 365 days
> *Actual results*
> The lifespan adjusting warning popup says that 365 days is greater than the
> configured maximum lifetime. This is not true, because, as you can see in the
> screenshot, we are creating tokens with {{unlimited lifetime}}
> *Expected result*
> The popup should not be displayed in case of unlimited token lifetime
> configurations.
> *Note*
> After clicking the {{Generate token anyway}} button, the token was created
> with the correct expiration time (1 year from today).
--
This message was sent by Atlassian Jira
(v8.20.10#820010)
