pzampino commented on PR #989:
URL: https://github.com/apache/knox/pull/989#issuecomment-2656881777

   > > Thanks, @tr0k, for getting back so quickly.
   > > @hingu8103 - based on the above, the only option you have is to create a 
separate service definition for 2.5.4 and add your change there. Or, 
alternatively, you may want to upgrade Hbase to at least 2.5.10. In any case, 
you may also want to ensure in your topology that you are using the appropriate 
service definition by applying its version (see sample 
[here](https://knox.apache.org/books/knox-2-1-0/dev-guide.html#service.xml)).
   > 
   > Hi folks, we're unclear on how Knox handles HBase versions. Does this mean 
it will use the 2.1.0 HBase UI service definition until HBase 2.5.9, and from 
HBase 2.5.10 onward, it will use the new 2.5.10 definitions?
   
   Knox doesn't know anything about the HBase version being proxied outside of 
the service definition. Knox will use the most recent version unless an 
explicit version is specified in the topology.
   
   So, by default, Knox will apply the 2.5.10 service definition. If the 
startupProgress rule also applies to previous HBase versions, then it makes 
sense to add it to the older service definition version(s). As previously 
noted, Knox topologies for which you wanted to use the older service 
definition(s) would require that the service definition version be explicitly 
configured therein.
   
   I did notice that the rewrite rule for 2.5.10 differs from the 2.1.0 
addition in this PR. Is that intentional?


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to