smolnar82 commented on code in PR #1001:
URL: https://github.com/apache/knox/pull/1001#discussion_r1978693819


##########
gateway-provider-security-authc-remote/src/main/java/org/apache/knox/gateway/filter/RemoteAuthFilter.java:
##########
@@ -203,12 +217,20 @@ private HttpURLConnection 
getHttpURLConnection(ServletContext servletContext) th
       KeystoreService keystoreService = 
services.getService(ServiceType.KEYSTORE_SERVICE);
       if (keystoreService != null) {
         try {
-          truststore = keystoreService.getTruststoreForHttpClient();
+          // Try topology-specific truststore first if configured

Review Comment:
   Given the updated logic, `getTrustStore()` should be a separate private 
method.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to