hanicz commented on PR #1029: URL: https://github.com/apache/knox/pull/1029#issuecomment-2835461489
> Looks good. My only note is do we have a usecase where this needs to be false? i.e. when we are not using https, what happens then does it break? There could be cases where users might not want to use https. We might have such usecase. I can check the SSL enabled gateway config and only add the secure attribute if it is set to true. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org