lmccay opened a new pull request, #1039:
URL: https://github.com/apache/knox/pull/1039

   …he presented client_id
   
   (It is very **important** that you created an Apache Knox JIRA for this 
change and that the PR title/commit message includes the Apache Knox JIRA ID!)
   
   ## What changes were proposed in this pull request?
   
   Currently, the support for client_id and client_secret treats the inclusion 
of the CLIENT_ID as a formality of the client credentials flow and since the 
actual client_id is resolvable from the client_secret, it is ignored.
   
   While there it may be arguable whether we need to enforce this, it seems a 
reasonable expectation that they should match. Let's close that gap.
   
   ## How was this patch tested?
   
   New unit tests added and all existing and new tests run.
   Manually tested.
   
   Please review [Knox Contributing 
Process](https://cwiki.apache.org/confluence/display/KNOX/Contribution+Process#ContributionProcess-GithubWorkflow)
 before opening a pull request.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to