[ https://issues.apache.org/jira/browse/KNOX-3138?focusedWorklogId=969007&page=com.atlassian.jira.plugin.system.issuetabpanels:worklog-tabpanel#worklog-969007 ]
ASF GitHub Bot logged work on KNOX-3138: ---------------------------------------- Author: ASF GitHub Bot Created on: 08/May/25 15:54 Start Date: 08/May/25 15:54 Worklog Time Spent: 10m Work Description: dk2k commented on PR #1033: URL: https://github.com/apache/knox/pull/1033#issuecomment-2863550081 @lmccay try-with-resources (TwR) was introduced exactly for these cases. If a closeable has a non-empty close() method, it should be called. Of course, you can call close() explicitly, but it's boilerplate code. I found this issue with static analysis tool. From my experience: if code is buildable after such changes, it means the changes are safe. Issue Time Tracking ------------------- Worklog Id: (was: 969007) Time Spent: 40m (was: 0.5h) > Implement try-with-resources for instances of Closeable > ------------------------------------------------------- > > Key: KNOX-3138 > URL: https://issues.apache.org/jira/browse/KNOX-3138 > Project: Apache Knox > Issue Type: Bug > Reporter: Dmitrii Kriukov > Priority: Major > Time Spent: 40m > Remaining Estimate: 0h > -- This message was sent by Atlassian Jira (v8.20.10#820010)