smolnar82 commented on PR #1042: URL: https://github.com/apache/knox/pull/1042#issuecomment-2865777411
Thanks, @hanicz, for your contribution. It was a good call to build the Set-Cookie header and add all values. Since you are doing that, I think there is an opportunity to improve the code. See the same (similar) code fragment in `WebSSOResource`:  I think it'd be beneficial to create a utility class that builds the `Set-Cookie` header, where all the params can be constants, the utility class can be tested, etc... Then resource, filter classes can use that class and its method(s). What do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org For queries about this service, please contact Infrastructure at: us...@infra.apache.org
