hanicz opened a new pull request, #1072:
URL: https://github.com/apache/knox/pull/1072

   ## What changes were proposed in this pull request?
   
   This XML validation is aiming to avoid cases like 
https://github.com/apache/knox/pull/1034 where a service definition were merged 
with an incorrect XML format. The build should fail in these cases.
   
   ## How was this patch tested?
   
   Ran mvn verify on correct and incorrect XMLs
   
   ```
   [ERROR] Failed to execute goal 
org.codehaus.mojo:xml-maven-plugin:1.1.0:validate (default) on project 
gateway-service-definitions: While parsing 
/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
 at 
file:/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
 line 23,  column 7: fatal error: The element type "rewrite" must be terminated 
by the matching end-tag "</rewrite>".
   [ERROR] While parsing 
/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
 at 
file:/Users/thanicz/dev/public/knox/gateway-service-definitions/src/main/resources/services/pinot/1.3.0/rewrite.xml,
 line 23,  column 7: fatal error: The element type "rewrite" must be terminated 
by the matching end-tag "</rewrite>". 
   ```


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscr...@knox.apache.org

For queries about this service, please contact Infrastructure at:
us...@infra.apache.org

Reply via email to